Skip to content

add test for missing numerator case #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 13, 2025
Merged

add test for missing numerator case #3715

merged 4 commits into from
Aug 13, 2025

Conversation

tataruty
Copy link
Contributor

Proposed changes

Noticed that there is no test for mirroring with Faction setting when Numerator is not specified, as i understand this case is valid and we expect 0% mirroring

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

NONE

@tataruty tataruty requested a review from a team as a code owner August 11, 2025 08:56
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 11, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.95%. Comparing base (0cd7d7f) to head (1312860).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3715      +/-   ##
==========================================
+ Coverage   86.90%   86.95%   +0.04%     
==========================================
  Files         128      128              
  Lines       15962    15962              
  Branches       62       62              
==========================================
+ Hits        13872    13879       +7     
+ Misses       1922     1917       -5     
+ Partials      168      166       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tataruty tataruty merged commit fdf340f into main Aug 13, 2025
65 of 66 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 13, 2025
@tataruty tataruty deleted the test/mirroring_no_numerator branch August 13, 2025 15:19
salonichf5 pushed a commit that referenced this pull request Aug 13, 2025
@tataruty @salonichf5
add test for missing numerator case (#3715)
c425703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@bjee19 bjee19 bjee19 approved these changes

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tataruty @sjberman @bjee19